Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

removed invalid jsdoc tag #8170

Closed
wants to merge 1 commit into from
Closed

removed invalid jsdoc tag #8170

wants to merge 1 commit into from

Conversation

jesselpalmer
Copy link
Member

The @methodOf tag was causing a warning on build. I removed the tag and changed the @name to match the previous comment blocks.

@mary-poppins
Copy link

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

  • Uses the issue template (#8170)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@caitp
Copy link
Contributor

caitp commented Jul 13, 2014

Hey @jesselpalmer I love that you're opening these!

Just a minor note, you could have updated #8163 by removing the unneeded commits instead of re-opening a new issue.

Additionally, since you're opening a number of these, it would be helpful to try and follow the Commit Message Guidelines to make a bit less work for us when we're merging these!

Anyways, don't worry too much, but it would be helpful to try and do these things in the future.

I think this looks okay, so I'm just going to test it first, and if it looks alright I'll merge it.

@caitp
Copy link
Contributor

caitp commented Jul 13, 2014

Merged, thanks =)

@caitp caitp closed this in a2c7cf9 Jul 13, 2014
@jesselpalmer
Copy link
Member Author

Great, thanks for the tip @caltp! I'll make sure to use the commit message guidelines going forward.

@jesselpalmer jesselpalmer deleted the removed-invalid-jsdoc-tag branch July 13, 2014 04:09
ckknight pushed a commit to ckknight/angular.js that referenced this pull request Jul 16, 2014
The @methodOf tag was causing a warning on build. I removed the tag and changed the @name to match
the previous comment blocks.

Closes angular#8170
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants