Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(misc/contribute): fix syntax highlighting of URLS #8169

Closed
wants to merge 1 commit into from

Conversation

caitp
Copy link
Contributor

@caitp caitp commented Jul 13, 2014

Closes #8168

@mary-poppins
Copy link

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

  • Uses the issue template (#8169)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@caitp
Copy link
Contributor Author

caitp commented Jul 13, 2014

/cc @petebacondarwin / @matsko can you two review this? @jesselpalmer has pointed out that the syntax highlighting in that document is very wrong, but I think this approach to fixing it might be a bit cleaner.

Anyways, I'll let you two figure that out, thanks.

@caitp caitp added type: docs and removed gh: PR labels Jul 13, 2014
@matsko
Copy link
Contributor

matsko commented Jul 14, 2014

@caitp I'll take care of this one.

@matsko matsko self-assigned this Jul 14, 2014
@btford btford added this to the 1.3.0 milestone Jul 21, 2014
@matsko
Copy link
Contributor

matsko commented Aug 11, 2014

@caitp LGTM. Great work.

@matsko matsko mentioned this pull request Aug 11, 2014
caitp added a commit that referenced this pull request Aug 18, 2014
@caitp caitp closed this in 6133c63 Aug 18, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants