This repository was archived by the owner on Apr 12, 2024. It is now read-only.
test(jqLite): make iframe contents() test less flaky #8157
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| // This test is potentially flaky on CI cloud instances, so there is a generous | ||
| // wait period... | ||
| waitsFor(function() { return tested; }, 2000); |
There was a problem hiding this comment.
still need to waitsFor because this is still asynchronous, but it''s not making a request anymore --- the fetch algorithm should abort this quickly.
Lets see how it does on travis...
|
/cc @vojtajina I think this should improve the flakes a bit... It's not perfect because the operation is still asynchronous by necessity, but at least it's not making an HTTP request. |
|
Merging this because this is flaking just too often on saucelabs :( I'm not sure how much this will help, but I think it should help at least a bit |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.