Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Corrected controller name in html binding #8133

Closed
wants to merge 1 commit into from
Closed

Conversation

sqdk
Copy link
Contributor

@sqdk sqdk commented Jul 10, 2014

Request Type: bug

How to reproduce: Go to https://docs.angularjs.org/api/ng/filter/orderBy and check the example in the bottom

Component(s):

Impact: small

Complexity: small

This issue is related to:

Detailed Description:

This is a very tiny problem with one of the demos on the orderBy doc page.

Other Comments:

Controller was set to Ctrl and controller was named ExampleController in js. Changed the html binding to ExampleController to fix the demo.

@mary-poppins
Copy link

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

  • Uses the issue template (#8133)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@mary-poppins
Copy link

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@mary-poppins
Copy link

CLA signature verified! Thank you!

Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes).

@sqdk sqdk added cla: yes and removed cla: no labels Jul 14, 2014
petebacondarwin pushed a commit that referenced this pull request Jul 15, 2014
ckknight pushed a commit to ckknight/angular.js that referenced this pull request Jul 16, 2014
@sqdk sqdk deleted the patch-1 branch June 30, 2017 12:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants