Update controller.ngdoc #8011
Update controller.ngdoc #8011
Conversation
If it is not recommended to use a constructor function to create controllers, why should it be shown as possible in the documentation? One of the most common complaints about AngularJS is that it doesn't enforce any variety of convention, this is intentional and I generally like this however if we can avoid outright bad implementations or examples I believe we should.
|
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
|
In response to the automated message, I read through the contributing guidelines, this is a small change to the docs that was initiated from the 'Improve These Docs' button, if there are changes I need to make I will gladly make them, including using the proper format. I believe the contributing docs state that small doc changes don't require that format though. |
For some reason changes weren't saved.
|
I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS. Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match. If you signed the CLA as a corporation, please let us know the company's name. Thanks a bunch! PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR. |
|
I signed the CLA just now. I'll check in soon to see that you received it. |
|
CLA signature verified! Thank you! Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes). |
|
+1 cc @btford |
If it is not recommended to use a global function to create controllers, why should it be shown as possible in the documentation? One of the most common complaints about AngularJS is that it doesn't enforce any convention. This is intentional and I generally like this. However if we can avoid outright bad implementations in examples I believe we should. Closes #8011
|
Thanks @cranesandcaff. I squashed, updated the commit message to follow our required format and then merged this. I then tweaked it slightly with c0e6527 |
If it is not recommended to use a global function to create controllers, why should it be shown as possible in the documentation? One of the most common complaints about AngularJS is that it doesn't enforce any convention. This is intentional and I generally like this. However if we can avoid outright bad implementations in examples I believe we should. Closes angular#8011
If it is not recommended to use a constructor function to create controllers, why should it be shown as possible in the documentation?
One of the most common complaints about AngularJS is that it doesn't enforce any variety of convention, this is intentional and I generally like this however if we can avoid outright bad implementations or examples I believe we should.
The only real reason to avoid doing so is to avoid introducing the potential new user to a somewhat complex new concept, however it is better to introduce new users to best practices instead of overly simplified examples.