This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(loader): allow 'ng' module to be extended with filters/directives/etc #7880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/etc Due to a regression in c0b4e2d, it is no longer possible to add new controllers, directives, filters, or animations to the `ng` module. This is becuase `config` blocks are always evaluated after regular invoke blocks, and the registration of these types depend on angular's config blocks to have been run. This solution simply ensures that `ng`'s config blocks are run before its invoke blocks are run. Closes angular#7709
|
So like I said in the issue, I'm not sure this was ever meant to be a supported use case... no guarantees on this landing >_- |
|
I think this is possibly useful for Batarang that may want to intercept + add components to the I think it might be worth mentioning that you should not do this in https://github.com/angular/angular-component-spec |
|
we should not do this. reopening the ng module is a hack. let's close this as won't fix and update the changelog with a note that this no longer works. |
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a regression in c0b4e2d, it is no longer possible to add new controllers, directives, filters, or animations to the
ngmodule. This is becuaseconfigblocks are always evaluated after regular invoke blocks, and the registration of these types depend on angular's config blocks to have been run.This solution simply ensures that
ng's config blocks are run before its invoke blocks are run.Closes #7709