-
Notifications
You must be signed in to change notification settings - Fork 27.4k
ngChange won't propagate if the model is invalid. #7866
Conversation
When a pattern is defined for an input field, ngChange is not evaluated if the input doesn't match the pattern. Only changes to or from matching patterns evaluate the ngChange expression.
I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS. Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match. If you signed the CLA as a corporation, please let us know the company's name. Thanks a bunch! PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR. |
OK, I've signed it. Sorry I was not aware of the restriction, and the automated process to make a change and submit it didn't tell me to sign the CLA (or wasn't obvious enough to me). Do I need to resubmit the pull request? |
CLA signature verified! Thank you! Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes). |
Thanks for the submission, @bernhard-hofmann . Can you change the wording to be more general, indicating that the change won't propagate if the model is invalid. |
Good point Jeff, thanks. I've renames the issue as you suggested. |
@bernhard-hofmann - I think @jeffbcross meant for you to change the content of your commit to be more general. |
When a pattern is defined for an input field, ngChange is not evaluated if the input doesn't match the pattern. Only changes to or from matching patterns evaluate the ngChange expression. See #7866
I merged @bernhard-hofmann's commit but then updated it to be more general. |
When a pattern is defined for an input field, ngChange is not evaluated if the input doesn't match the pattern. Only changes to or from matching patterns evaluate the ngChange expression.