Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

ngChange won't propagate if the model is invalid. #7866

Closed
wants to merge 1 commit into from
Closed

ngChange won't propagate if the model is invalid. #7866

wants to merge 1 commit into from

Conversation

bernhard-hofmann
Copy link
Contributor

When a pattern is defined for an input field, ngChange is not evaluated if the input doesn't match the pattern. Only changes to or from matching patterns evaluate the ngChange expression.

When a pattern is defined for an input field, ngChange is not evaluated if the input doesn't match the pattern. Only changes to or from matching patterns evaluate the ngChange expression.
@mary-poppins
Copy link

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@bernhard-hofmann
Copy link
Contributor Author

OK, I've signed it. Sorry I was not aware of the restriction, and the automated process to make a change and submit it didn't tell me to sign the CLA (or wasn't obvious enough to me).

Do I need to resubmit the pull request?

@mary-poppins
Copy link

CLA signature verified! Thank you!

Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes).

@jeffbcross
Copy link
Contributor

Thanks for the submission, @bernhard-hofmann . Can you change the wording to be more general, indicating that the change won't propagate if the model is invalid. ngPattern is just one way a model can be invalid.

@jeffbcross jeffbcross self-assigned this Jul 25, 2014
@jeffbcross jeffbcross modified the milestone: 1.3.0-beta.18 Jul 25, 2014
@jeffbcross jeffbcross removed their assignment Jul 25, 2014
@bernhard-hofmann bernhard-hofmann changed the title ngChange might not evaluate due to ngPattern ngChange won't propagate if the model is invalid. Jul 26, 2014
@bernhard-hofmann
Copy link
Contributor Author

Good point Jeff, thanks. I've renames the issue as you suggested.

@petebacondarwin
Copy link
Contributor

@bernhard-hofmann - I think @jeffbcross meant for you to change the content of your commit to be more general.

petebacondarwin pushed a commit that referenced this pull request Jul 26, 2014
When a pattern is defined for an input field, ngChange is not evaluated
if the input doesn't match the pattern. Only changes to or from matching
patterns evaluate the ngChange expression.

See #7866
@petebacondarwin
Copy link
Contributor

I merged @bernhard-hofmann's commit but then updated it to be more general.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants