Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Rename int() to toInt() - issue #1304 #7768

Closed
wants to merge 1 commit into from
Closed

Rename int() to toInt() - issue #1304 #7768

wants to merge 1 commit into from

Conversation

Crozin
Copy link

@Crozin Crozin commented Jun 10, 2014

No description provided.

@mary-poppins
Copy link

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

  • Uses the issue template (#7768)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@mary-poppins
Copy link

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@Crozin Crozin added cla: no and removed cla: yes labels Jun 10, 2014
@Crozin
Copy link
Author

Crozin commented Jun 10, 2014

My CLA agreement should be signed now.

@IgorMinar
Copy link
Contributor

the cla verification still fails because of email address mismatch, please check the mail you used in the git commit here: https://github.com/angular/angular.js/pull/7768.patch and use that to sign CLA.

can you also rebase this PR please?

@caitp
Copy link
Contributor

caitp commented Oct 16, 2014

@Crozin could you ping me once you've signed the CLA and rebased please? Thanks --- If you need any help with that, don't hesitate to ask me, too

@Crozin
Copy link
Author

Crozin commented Oct 27, 2014

Hey, I've added additional email address to my CLA, please let me know if it's alright now.

lgalfaso added a commit to lgalfaso/angular.js that referenced this pull request Dec 28, 2014
Renamed the internal function `int` to `toInt` as `int` is a reserved word

Closes angular#7768
lgalfaso added a commit to lgalfaso/angular.js that referenced this pull request Dec 28, 2014
Renamed the internal function `int` to `toInt` as `int` is a reserved word

Closes angular#7768
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants