Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Add line breaks after images #7748

Closed
wants to merge 1 commit into from
Closed

Add line breaks after images #7748

wants to merge 1 commit into from

Conversation

NV
Copy link
Contributor

@NV NV commented Jun 9, 2014

https://docs.angularjs.org/guide/databinding

line-break

I don’t know what ngdoc format is, but this change would work for markdown.

@mary-poppins
Copy link

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

  • Uses the issue template (#7748)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@mary-poppins
Copy link

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@NV NV added cla: no and removed cla: yes labels Jun 9, 2014
@@ -9,7 +9,7 @@ When the model changes, the view reflects the change, and vice versa.

## Data Binding in Classical Template Systems

<img class="right" src="img/One_Way_Data_Binding.png"/>
<img class="right" src="img/One_Way_Data_Binding.png"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trailing whitespace?

@caitp
Copy link
Contributor

caitp commented Jun 9, 2014

This mostly looks good to me, I'm just going to fix the trailing whitespace.

@caitp caitp closed this in 1064686 Jun 9, 2014
@NV
Copy link
Contributor Author

NV commented Jun 9, 2014

Two trailing whitespaces equals <br> in Markdown.

@caitp
Copy link
Contributor

caitp commented Jun 9, 2014

Right, but you don't really want that in source files. It's not obvious what it means, and it's incredibly likely that it would be broken later on the next time someone absentmindedly edits the file. <br /> is very clear in what it means, and even if you aren't familiar with HTML, you know it means "something" and isn't just absentmindedly added trailing whitespace. not to mention that text editors frequently remove trailing spaces automatically.

@NV
Copy link
Contributor Author

NV commented Jun 9, 2014

I see, whatever works best.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants