This repository was archived by the owner on Apr 12, 2024. It is now read-only.
docs(error/$rootScope/inprog): improve understanding and diagnosis of the error #7719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
|
You can see the new error doc page in action here: http://ci.angularjs.org/job/angular.js-pete/570/artifact/build/docs/error/$rootScope/inprog |
| ); | ||
| ``` | ||
|
|
||
| It is not possible to tell which from the stack trace, but we happen know in this case that it is |
There was a problem hiding this comment.
Magic thanks
| }); | ||
| }); | ||
| } | ||
| ``` | ||
|
|
||
| The controller constructor is always instantiated from within an $apply cycle, so if the third-party component called our callback synchronously, we'd be trying to enter the $apply again. | ||
| We expect that our callback will be call asynchronously, and so from outside Angular. Therefore, we |
|
Closed by 4124a65 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change improves the documentation related to "$digest/$apply already in progress" errors.
It describes common scenarios where this error occurs and shows a demonstration of debugging a situation where the error has occurred, including a runnable example.
See #5549