This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($http): reject $http promise when timeout occurs #7688
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, timed out $http requests would result in a fulfilled promise, rather than a rejection.
This CL corrects this unexpected behaviour.
BREAKING CHANGE:
Currently, request timeout is treated as a successful request. This is unexpected, as a timeout is
generally a failure, however it's possible some applications depend on this behaviour.
If your application depends on this, it's possible to migrate by simply moving the code which handles
a timeout into a rejection/error handler, rather than a success handler.
Example:
$http.get('/some/slow/resource', {
timeout: 1
}).error(function(res) {
if (res.statusText === "Timedout") {
console.log("request timed out!");
}
});
|
I think it should be |
|
We're basically inventing a statusText for this, which might not happen in the version of this that ships. I'll see what Igor thinks about it later today |
caitp
added a commit
that referenced
this pull request
Jun 6, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, timed out $http requests would result in a fulfilled promise, rather than a rejection. This CL corrects this unexpected behaviour.
BREAKING CHANGE:
Currently, request timeout is treated as a successful request. This is unexpected, as a timeout is generally a failure, however it's possible some applications depend on this behaviour.
If your application depends on this, it's possible to migrate by simply moving the code which handles a timeout into a rejection/error handler, rather than a success handler.
Example:
Fixes #7686