This repository was archived by the owner on Apr 12, 2024. It is now read-only.
docs($rootScope): fix incorrect docs and make them clearer #7598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
During the first $digest loop after registering a $watch the listener always run, so the example was incorrect (here's a plunk proving it: http://plnkr.co/edit/NRM4UIp9rk28VbylAtvl). Also, I'm making it clearer that if the value doesn't change, the listener doesn't get called on subsequent $digest loops.
|
I've filled out the issue template, but the checkbox is disabled for me. |
rodyhaddad
pushed a commit
that referenced
this pull request
May 29, 2014
During the first $digest loop after registering a $watch the listener always run, so the example was incorrect Closes #7598
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request Type: docs
How to reproduce:
Component(s): scope
Impact: large
Complexity: small
This issue is related to:
Detailed Description:
During the first digest loop after registering a $watch
the listener always run, so the example about the $digest cycles in the $rootScope docs was incorrect
(here's a plunk to prove it:
http://plnkr.co/edit/NRM4UIp9rk28VbylAtvl).
Also, we can make it clearer that if the value doesn't change,
the listener doesn't run on subsequent $digest loops.
Other Comments: