This repository was archived by the owner on Apr 12, 2024. It is now read-only.
refactor($parse): add lgalfaso's refactors and suggestions #7571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
| @@ -1014,7 +996,7 @@ function $ParseProvider() { | |||
| }; | |||
|
|
|||
|
|
|||
| this.$get = ['$filter', '$sniffer', '$log', function($filter, $sniffer, $log) { | |||
| this.$get = ['$filter', '$sniffer', '$log', function($filter, $sniffer) { | |||
There was a problem hiding this comment.
The $log annotation is still present here, but the variable was removed?
There was a problem hiding this comment.
Oops!
Fixed, thank you :-)
After removing the json and unwrapPromise mode, some parameters and methods were no longer used.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lgalfaso's PR #7543 had two aspects of it that I didn't include in my last changes to $parse (#7552, #7555)
constant, and the Parser should deduce that a primaryconstantis also aliteral