This repository was archived by the owner on Apr 12, 2024. It is now read-only.
feat($compile): support transcluding SVG nodes when there is no root <svg> node #7384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…svg> node Due to angular@f0e12ea, it is now possible to have a directive whose template content is SVG. However, the following issue arises: A template like <replaces-with-svg-and-transcludes> <g> <circle r=50 cx=0 cy=0 /> <text>My circle!</text> </g> </replaces-with-svg-and-transcludes> Would not work as expected, due to the group, circle and text nodes being parsed as HTMLUnknownElements, for not being parsed in an SVG context. This change enables transcluded SVG content to work when parsed as non-HTML content, with the cost of linking the transcluded elements again.
…uery used `toHaveClass()` is a useful matcher, but unfortunately leverages jQuery/jqLite's hasClass() method. jQuery's class API does not support SVG nodes, while angular's does. Therefore, some extra work needs to be done to make this work for both libraries.
caitp
changed the title
|
http://plnkr.co/edit/pGB1RWFKYMvUW0ImHqyE?p=preview plunkr from the original issue |
|
Closing this, rationale in #7383 (comment) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL is a work in progress, and is not meant to be committed in this state.
Due to f0e12ea, it is now possible to have a directive whose template content is SVG.
However, the following issue arises:
A template like
Would not work as expected, due to the group, circle and text nodes being
parsed as HTMLUnknownElements, for not being parsed in an SVG context.
This change enables transcluded SVG content to work when parsed as non-HTML
content, with the cost of linking the transcluded elements again.
Fixes #7383