This repository was archived by the owner on Apr 12, 2024. It is now read-only.
_angular is redundant
#7215
Closed
_angular is redundant
#7215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Going through the commit history on GitHub, the `_angular` is for noConflict mode, the case where you have an old reference to a variable called Angular you want to preserve. Here is the commit that added _angular in : 12ba6ce This feature was later removed here: 9faabd1 The variable 'made it through', it's redundant now.
|
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
|
I've signed the CLA btw. Enjoy. |
petebacondarwin
pushed a commit
that referenced
this pull request
Apr 24, 2014
Going through the commit history on GitHub, the `_angular` is for noConflict mode, the case where you have an old reference to a variable called Angular you want to preserve. Here is the commit that added _angular in : https://github.com/angular/angular.js/commit/ 12ba6ce This feature was later removed here: 9faabd1 The variable 'made it through', it's redundant now. Closes #7215
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request Type: bug
How to reproduce: _angular variable is redundant in the source
Component(s): misc core
Impact: small
Complexity: small
This issue is related to:
Detailed Description:
Other Comments:
Going through the commit history on GitHub, the
_angularis for noConflict mode, the case where you have an old reference to a variable called Angular you want to preserve.Here is the commit that added _angular in : 12ba6ce
This feature was later removed here:
9faabd1
The variable 'made it through', it's redundant now.