Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix(input): allow use of integers in ng-true-value #7124

Closed
wants to merge 1 commit into from
Closed

fix(input): allow use of integers in ng-true-value #7124

wants to merge 1 commit into from

Conversation

Eleeleth
Copy link

Request Type: bug

How to reproduce: PR for: #7109

Plunker from that issue: http://plnkr.co/edit/VxJVpbRV4vkbivKpAUUn?p=preview

Component(s): forms

Impact: medium

Complexity: small

This issue is related to:

Detailed Description:

Other Comments:

Resolves an issue where values of '1' in ng-true-value would not set the
checkbox to a checked state when the scope's value was 1.

Closes #7109

@mary-poppins
Copy link

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

  • Uses the issue template (#7124)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

Resolve an issue where values of '1' in ng-true-value would not set the
checkbox to a checked state when the scope's value was 1.

Closes #7109
@mary-poppins
Copy link

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@Eleeleth Eleeleth added cla: no and removed cla: yes labels Apr 18, 2014
@mary-poppins
Copy link

CLA signature verified! Thank you!

Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes).

@Narretz
Copy link
Contributor

Narretz commented Jul 4, 2014

fixed in c90cefe

@Narretz Narretz closed this Jul 4, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ng-true-value doesn't work with integers
4 participants