Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Update tutorial documentation step_00.ngdoc #6960

Closed
wants to merge 1 commit into from

Conversation

martinjezek
Copy link
Contributor

Request Type: docs

How to reproduce:

Component(s):

Impact: small

Complexity: small

This issue is related to:

Detailed Description:

As a developer learning AngularJS through PhoneCat Tutorial App on page 0 - Bootstrapping, I'd like to see a code in tutorial's page in the same way like is coded within demo project. Tutorial uses lib and css folders for linking plugins instead of bower_components.

In Pull Request #6960 I fixed this small issue ;)

Cheers, Martin

angular-phonecat/app/index.html

  <link rel="stylesheet" href="../bower_components/bootstrap/dist/css/bootstrap.css">
  <link rel="stylesheet" href="css/app.css">
  <script src="../bower_components/angular/angular.js"></script>

AngularJS: Tutorial: 0 - Bootstrapping

  <link rel="stylesheet" href="css/app.css">
  <link rel="stylesheet" href="css/bootstrap.css">
  <script src="lib/angular/angular.js"></script>

and

  <script src="lib/angular/angular.js">

Other Comments:

This change/branch was created directly through improve this doc button

@mary-poppins
Copy link

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

  • Uses the issue template (#6960)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@mary-poppins
Copy link

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@martinjezek
Copy link
Contributor Author

CLA signature > done

@mary-poppins
Copy link

CLA signature verified! Thank you!

Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes).

@btford
Copy link
Contributor

btford commented Apr 3, 2014

Thanks @martinjezek!

@btford btford closed this in c369563 Apr 3, 2014
@btford
Copy link
Contributor

btford commented Apr 3, 2014

Landed as c369563.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants