Increase readability for test fail line #6943
Conversation
|
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
|
I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS. Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match. If you signed the CLA as a corporation, please let us know the company's name. Thanks a bunch! PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR. |
| @@ -244,7 +244,7 @@ To run the test, do the following: | |||
| <tr ng-repeat="i in [0, 1, 2, 3, 4, 5, 6, 7]"><td>{{i+1}}</td></tr> | |||
| </table> | |||
|
|
|||
| * Make the unit test fail by changing the `toBe(3)` statement to `toBe(4)`. | |||
| * Make the unit test fail by changing the number in the `expect(scope.phones.length).toBe(3)` statement. | |||
There was a problem hiding this comment.
I don't really think this is more clear, maybe "by changing the expect(scope.phones.length).toBe(3) statement to use toBe(4)" would be better
|
+1 @caitp - do you want to change and merge that? |
|
sgtm |
Increase readability for test fail line Closes #6943
|
thanks very much @bricejlin |
Increase readability for test fail line Closes angular#6943
No description provided.