docs(ngMock/angular-mocks) added response to whenPOST mock #6761
Conversation
The ```whenPOST``` method should return a response object containing status, response body and headers. If omitted the following error will be thrown: ```Uncaught TypeError: Cannot read property '2' of undefined``` The documentation doesn't make it very clear, so I think it will be appropriate to add it here.
|
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
sorenlouv
changed the title
|
I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS. Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match. If you signed the CLA as a corporation, please let us know the company's name. Thanks a bunch! PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR. |
1 similar comment
|
I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS. Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match. If you signed the CLA as a corporation, please let us know the company's name. Thanks a bunch! PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR. |
|
Hi @caitp |
|
I can merge this later today, I'm not sure why it's triaged the way it is though. I worry that this feature might end up removed at some point though, since it isn't being used in any of the core tests. I dunno. |
… 1st param The `whenPOST` method should return a response object containing status, response body and headers. If omitted the following error will be thrown: `Uncaught TypeError: Cannot read property '2' of undefined` The documentation doesn't make it very clear, so I think it will be appropriate to add it here. Closes #6761
Request Type: docs
How to reproduce: Use whenPOST without returning a response
Component(s): ngMocks
Impact: small
Complexity: small
This issue is related to: whenPOST (mocking)
Detailed Description: The
whenPOSTmethod should return a response containing status, response body and headers. If omitted the following error will be thrown:Uncaught TypeError: Cannot read property '2' of undefinedThe documentation doesn't make it very clear, so I think it will be appropriate to add.