Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Clarifying some confusing points on migration doc #6756

Closed
wants to merge 2 commits into from

Conversation

alexdmiller
Copy link
Contributor

Some parts of the migration doc were confusing or not totally accurate, based on my experience migrating an AngularJS project from 1.0 to 1.2.7. I've tried to update the doc to clarify some confusing points.

I am completely new to AngularJS. Some of these documentation changes themselves might be inaccurate. Please look over carefully!

Some parts of the migration doc were confusing or not totally accurate, based on my experience migrating an AngularJS project from 1.0 to 1.2.7. I've tried to update the doc to clarify some confusing points.

I am completely new to AngularJS. Some of these documentation changes themselves might be inaccurate. Please look over carefully!
@mary-poppins
Copy link

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

  • Uses the issue template (#6756)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@mary-poppins
Copy link

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

If you see the following error message:

```
A Node was inserted somewhere it doesn't belong
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure that we don't throw an error with this message. Isn't it something specific to your app?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This error message is not thrown by Angular, but I think it is caused by DOM manipulations performed by Angular. This is the specific change that caused the error in our app:

c47abd0#diff-c63111838cf41936324951b4dfa9fd60

@IgorMinar
Copy link
Contributor

all but the last hunk in the diff look good to me. can you provide more information about the last error?

@IgorMinar IgorMinar self-assigned this Mar 19, 2014
@IgorMinar IgorMinar added this to the 1.3.0-beta.3 milestone Mar 19, 2014
@Narretz
Copy link
Contributor

Narretz commented Mar 20, 2014

I think the version numbers should be less specific. The migration guide is for updating from 1.0.x to 1.2.x, so this should be reflected in the text.

I've changed "1.2.7" to "1.2" and removed the section about DOM manipulation, because this might be too specific to my app.
@Foxandxss
Copy link
Member

I like the idea to expand that last hunk. But I would reword it a little bit to match the doc style.

@alexdmiller
Copy link
Contributor Author

Foxandxss, I decided to remove the last hunk because I think it might be a very specific part of how my app behaves... unless this is a common known issue?

@mary-poppins
Copy link

CLA signature verified! Thank you!

Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes).

@btford btford modified the milestones: 1.3.0-beta.4, 1.3.0-beta.3 Mar 24, 2014
@btford
Copy link
Contributor

btford commented Mar 25, 2014

I think we should merge this now that the questionable part was amended. Ping @IgorMinar.

Thanks, @alexdmiller!

@IgorMinar IgorMinar closed this in 372e31a Mar 26, 2014
@IgorMinar
Copy link
Contributor

done. thanks!

IgorMinar pushed a commit that referenced this pull request Mar 26, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants