-
Notifications
You must be signed in to change notification settings - Fork 27.4k
Clarifying some confusing points on migration doc #6756
Conversation
Some parts of the migration doc were confusing or not totally accurate, based on my experience migrating an AngularJS project from 1.0 to 1.2.7. I've tried to update the doc to clarify some confusing points. I am completely new to AngularJS. Some of these documentation changes themselves might be inaccurate. Please look over carefully!
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS. Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match. If you signed the CLA as a corporation, please let us know the company's name. Thanks a bunch! PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR. |
If you see the following error message: | ||
|
||
``` | ||
A Node was inserted somewhere it doesn't belong |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure that we don't throw an error with this message. Isn't it something specific to your app?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This error message is not thrown by Angular, but I think it is caused by DOM manipulations performed by Angular. This is the specific change that caused the error in our app:
all but the last hunk in the diff look good to me. can you provide more information about the last error? |
I think the version numbers should be less specific. The migration guide is for updating from 1.0.x to 1.2.x, so this should be reflected in the text. |
I've changed "1.2.7" to "1.2" and removed the section about DOM manipulation, because this might be too specific to my app.
I like the idea to expand that last hunk. But I would reword it a little bit to match the doc style. |
Foxandxss, I decided to remove the last hunk because I think it might be a very specific part of how my app behaves... unless this is a common known issue? |
CLA signature verified! Thank you! Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes). |
I think we should merge this now that the questionable part was amended. Ping @IgorMinar. Thanks, @alexdmiller! |
done. thanks! |
Some parts of the migration doc were confusing or not totally accurate, based on my experience migrating an AngularJS project from 1.0 to 1.2.7. I've tried to update the doc to clarify some confusing points.
I am completely new to AngularJS. Some of these documentation changes themselves might be inaccurate. Please look over carefully!