Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Clarify behaviour of $promise in ngResource when using an interceptor #6753

Closed
wants to merge 1 commit into from

Conversation

alexsanford
Copy link
Contributor

Request Type: docs

How to reproduce:

Component(s): ngResource

Impact:

Complexity:

This issue is related to:

Detailed Description:

When an interceptor is used in ngResource, the $promise is no longer resolved with the resource object, but instead with the value returned by the interceptor. This is now specified in the docs.

Other Comments:

@mary-poppins
Copy link

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

  • Uses the issue template (#6753)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@mary-poppins
Copy link

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@mary-poppins
Copy link

CLA signature verified! Thank you!

Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes).

1 similar comment
@mary-poppins
Copy link

CLA signature verified! Thank you!

Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes).

@caitp caitp closed this in 08354ae Mar 27, 2014
caitp pushed a commit that referenced this pull request Mar 27, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants