This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Update nonassign.ngdoc #6725
Closed
Update nonassign.ngdoc #6725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It might seem obvious that if you don't supply "bind" attribute in this case, you'll get an error, but I feel this is worth adding to the doc, because this was my error, and the documentation led me to try every permutation of attribute values on <my-directive>1, and completely missed the fact that <my-directive>2 in my code didn't have ANY attribute. If my proposed edit had been there, I might have found my problem earlier.
|
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
vojtajina
pushed a commit
that referenced
this pull request
Mar 21, 2014
It might seem obvious that if you don't supply "bind" attribute in this case, you'll get an error, but I feel this is worth adding to the doc. Closes #6725
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request Type: docs
How to reproduce:
Component(s): $compile
Impact: medium
Complexity: small
This issue is related to:
Detailed Description:
It might seem obvious that if you don't supply "bind" attribute in this case, you'll get an error, but I feel this is worth adding to the doc, because this was my error, and the documentation led me to try every permutation of attribute values on 1, and completely missed the fact that 2 in my code didn't have ANY attribute. If my proposed edit had been there, I might have found my problem earlier.
Other Comments: