This repository was archived by the owner on Apr 12, 2024. It is now read-only.
feat(filterFilter): support filterFilter for object literal collection #6695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filterFilter was previously only available to array/array-like collections, but ngRepeat supports iterating over object literals. This PR enables filtering functionality over object literal properties. Fixes #6490
|
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
|
This is #6508 on an isolated branch |
|
+1 |
petebacondarwin
force-pushed
the
master
branch
from
02dc2aa to
fd2d6c0
Compare
jeffbcross
force-pushed
the
master
branch
2 times, most recently
from
cad9560 to
f294244
Compare
jeffbcross
force-pushed
the
master
branch
4 times, most recently
from
e8dc429 to
e83fab9
Compare
petebacondarwin
force-pushed
the
master
branch
from
4dd5a20 to
998c61c
Compare
| }; | ||
|
|
||
| // Helper to return the specified keys of an object as a new object (for test verification) | ||
| var stringifiedProps = function(obj, array) { |
There was a problem hiding this comment.
I don't really see why you need this...
|
+1 |
|
We decided that we will not support object collections for filterFilter. In fact, it will now throw when used with an object. The suggested solution is to convert your objects to arrays; you can use a filter for that, too: https://code.angularjs.org/snapshot/docs/error/filter/notarray |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request Type: feature
How to reproduce: Feed an object literal into an ngRepeat to loop over its properties with a filter in use, as shown here: http://plnkr.co/edit/mMvAgQgILcBVkbT2q4z4?p=preview
Component(s): misc core
Impact: small
Complexity: small
This issue is related to:
Detailed Description:
I switched the primary filterFilter iteration method to one that supports both array and object literal collections and added tests for the object version.
Other Comments:
filterFilter was previously only available to array/array-like collections,
but ngRepeat supports iterating over object literals. This PR enables
filtering functionality over object literal properties.
Fixes #6490