Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix(input):URL validation does not recognize URLs with no protocol #6650

Closed
wants to merge 1 commit into from

Conversation

SekibOmazic
Copy link
Contributor

Request Type:

How to reproduce:

Component(s):

Impact: small

Complexity: small

This issue is related to:

Detailed Description:

Now recognizes URLs without protocol but it is far away from full-blown URL validator

Other Comments:

change the url regexp to recognize urls without protocol

closes #6634

change the url regexp to recognize urls without protocol

closes angular#6634
@mary-poppins
Copy link

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

  • Uses the issue template (#6650)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@lefos987 lefos987 self-assigned this Mar 11, 2014
@lefos987 lefos987 assigned lefos987 and unassigned lefos987 Mar 12, 2014
@lefos987 lefos987 removed their assignment Mar 12, 2014
@auser auser self-assigned this Mar 17, 2014
@SekibOmazic
Copy link
Contributor Author

@auser Should I close the PR as the #6634 has been closed (won't fix or so) ? Or do you guys (core team) do that? Don't know what's the procedure.

@auser
Copy link
Contributor

auser commented Mar 21, 2014

I'll close this now as won't fix.

@auser auser closed this Mar 21, 2014
@SekibOmazic SekibOmazic deleted the issue-6634 branch March 28, 2014 13:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URL validation does not recognize URLs with no protocol
4 participants