Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Update module.ngdoc #6628

Closed
wants to merge 1 commit into from
Closed

Conversation

drbitslayer
Copy link

Request Type: docs

How to reproduce:

Component(s):

Impact:

Complexity: small

This issue is related to:

Detailed Description:

there's no reference to a document about organizing modules

Other Comments:

Really would like to see the document to which the author is referring.

@mary-poppins
Copy link

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

  • Uses the issue template (#6628)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@mary-poppins
Copy link

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@gsklee
Copy link
Contributor

gsklee commented Mar 10, 2014

This modification isn't particularly helpful at all... I think there were some DoubleClick members sharing their insights on the same topic during January's ng-conf, I'll probably find the video and link to it instead.

gsklee pushed a commit to gsklee/angular.js that referenced this pull request Mar 10, 2014
Explicitly mentions Google DoubleClick team's presentation during ng-conf 2014 in place of the original vague wording.

Closes angular#6628
@lefos987 lefos987 added this to the Backlog milestone Mar 12, 2014
@lefos987
Copy link
Contributor

This is a duplicate of #6629 . @drbitslayer Thanks a lot for raising this but in #6629 the actual reference to the document that you mention is added in the PR.
I will close this now but let me know if you think there is a reason to reopen it.
Thanks

@lefos987 lefos987 closed this Mar 12, 2014
btford pushed a commit that referenced this pull request Mar 17, 2014
vojtajina pushed a commit that referenced this pull request Mar 21, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants