Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

style: enable jscs requireLeftStickedOperators rule #6544

Closed
wants to merge 1 commit into from
Closed

style: enable jscs requireLeftStickedOperators rule #6544

wants to merge 1 commit into from

Conversation

TimotheeJeannin
Copy link
Contributor

Request Type:

How to reproduce:

Component(s):

Impact: small

Complexity: small

This issue is related to:

Detailed Description:

Enable the jscs requireLeftStickedOperators rule.

Other Comments:

Some attribute comments have been moved from

, true  /* restrictBrowers */ ,

to

, /* restrictBrowers */ true,

@mary-poppins
Copy link

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

  • Uses the issue template (#6544)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@mary-poppins
Copy link

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@caitp
Copy link
Contributor

caitp commented Mar 4, 2014

I don't think this is a problem, I would say merge it if it matches up well with the styleguide. I kind of want a second opinion before changing the style check rules for the tree, though.

@TimotheeJeannin
Copy link
Contributor Author

Ok.

Does that mean the rules in the .jscs.json.todo file are not the rules you're planning to include in the jscs code style check ?

@mary-poppins
Copy link

CLA signature verified! Thank you!

Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes).

@tbosch tbosch self-assigned this Mar 6, 2014
@tbosch
Copy link
Contributor

tbosch commented Mar 6, 2014

Hi @TimotheeJeannin,
thank you a lot!
We haven't publicly said that we would like to enforce the checks in .jscs.json.todo. However, you did understand correctly!

Merging this now.

P.S.: If you would like to send PRs for enabling more options, this would be awesome!

@tbosch tbosch closed this in 9335378 Mar 6, 2014
@tbosch tbosch removed their assignment Mar 6, 2014
@TimotheeJeannin TimotheeJeannin deleted the jscs-comma branch March 6, 2014 13:53
@TimotheeJeannin
Copy link
Contributor Author

Thank you. :)

btford pushed a commit that referenced this pull request Mar 7, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants