-
Notifications
You must be signed in to change notification settings - Fork 27.4k
fix(select): ensure option list is repainted on IE9 #6240
base: master
Are you sure you want to change the base?
Conversation
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
@@ -301,6 +303,18 @@ var selectDirective = ['$compile', '$parse', function($compile, $parse) { | |||
}); | |||
} | |||
|
|||
function forceRepaint(selectElement) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could the other code which performs this task be factored out into a function and just called here if the options don't look right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, when else do we have options that don't look right? I was hoping this can be solving #5132 with force repaint on iOS as well, but that's failing in more mysterious way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean, this looks similar to where the list of options gets reconstructed in $render(), so it may be possible to make use of the existing code.
But then again, it might not :p
02dc2aa
to
fd2d6c0
Compare
cad9560
to
f294244
Compare
e8dc429
to
e83fab9
Compare
4dd5a20
to
998c61c
Compare
Fixes #6211