Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix(select): ensure option list is repainted on IE9 #6240

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

clkao
Copy link
Contributor

@clkao clkao commented Feb 13, 2014

Fixes #6211

@mary-poppins
Copy link

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

  • Uses the issue template (#6240)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@@ -301,6 +303,18 @@ var selectDirective = ['$compile', '$parse', function($compile, $parse) {
});
}

function forceRepaint(selectElement) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could the other code which performs this task be factored out into a function and just called here if the options don't look right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, when else do we have options that don't look right? I was hoping this can be solving #5132 with force repaint on iOS as well, but that's failing in more mysterious way.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, this looks similar to where the list of options gets reconstructed in $render(), so it may be possible to make use of the existing code.

But then again, it might not :p

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ng-options placeholder in select not removed in IE9
6 participants