This repository was archived by the owner on Apr 12, 2024. It is now read-only.
removing confusing use of hoisting #6207
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why do ``` var ... return exports; function for exports... another function for exports... ``` Why put return statement in the middle? This "hoisting hack" makes the code harder to read and will likely confuse beginners not familiar with the concept. Unless there's some really good reason to nest the return statement between properties & methods it should not be thus.
|
I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS. Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match. If you signed the CLA as a corporation, please let us know the company's name. Thanks a bunch! PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR. |
IgorMinar
pushed a commit
to IgorMinar/angular.js
that referenced
this pull request
Feb 10, 2014
khepin
pushed a commit
to khepin/angular.js
that referenced
this pull request
Feb 19, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why do
Why put return statement in the middle? This "hoisting hack" makes the code harder to read and will likely confuse beginners not familiar with the concept. Unless there's some really good reason to nest the return statement between properties & methods it should not be thus.