Update ngEventDirs.js #6196
Update ngEventDirs.js #6196
Conversation
The documentation states only the "action" attribute triggers this, which is incorrect. When using the attribute "data-action" (as for AJAX control, attempting to bypass the "action" attribute but still make it obvious what its for), Angular thinks this is also classified as "action" and continues with the page submission.
|
I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS. Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match. If you signed the CLA as a corporation, please let us know the company's name. Thanks a bunch! PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR. |
|
CLA signature verified! Thank you! Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes). |
|
Sooo, this is technically correct (although it's missing the Maybe it would make more sense to change this to only look at the action attribute, in particular. edit huh, apparently I'm wrong (at least, testing on jsfiddle I seem to be wrong :c). In that case I'll merge this. |
|
Oh, I really messed up that commit message, sigh. I'm not going to bother correcting that, so... yeah. |
… attributes The documentation states only the "action" attribute triggers this, which is incorrect. When using the attribute "data-action" (as for AJAX control, attempting to bypass the "action" attribute but still make it obvious what its for), Angular thinks this is also classified as "action" and continues with the page submission. Closes angular#6196
NgSubmit
The documentation states only the "action" attribute triggers a page submission, which is incorrect. When using the attribute "data-action" (as for AJAX control, attempting to bypass the "action" attribute but still make it obvious what it's for), Angular thinks this is also classified as the attribute "action" and continues with the page submission.