Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Update jqLite.js #6171

Closed
wants to merge 2 commits into from
Closed

Update jqLite.js #6171

wants to merge 2 commits into from

Conversation

githubjeka
Copy link
Contributor

Сorrect link.

@mary-poppins
Copy link

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@mary-poppins
Copy link

CLA signature verified! Thank you!

Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes).

@caitp caitp closed this in 56cc7bc Feb 11, 2014
@caitp
Copy link
Contributor

caitp commented Feb 11, 2014

Thanks! I'm not sure that the difference really means a whole lot in modern jQuery, but I guess it makes more sense to the eye. Merged~

@githubjeka githubjeka deleted the patch-1 branch February 12, 2014 05:02
@mgol
Copy link
Member

mgol commented Feb 12, 2014

Actually, I put links to on/off instead of bind/unbind on purpose since jqLite is just aliasing on/off and bind/unbind are the old APIs so IMO it's better to read the new ones.

Maybe the current way is preferred, just wanted to point out this wasn't a mistake, it was deliberate.

@githubjeka
Copy link
Contributor Author

I know ) but I guess it makes more sense to the eye (c)

khepin pushed a commit to khepin/angular.js that referenced this pull request Feb 19, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants