This repository was archived by the owner on Apr 12, 2024. It is now read-only.
chore(dependencies): upgrade q to (hopefully) prevent process.nextTick error spam #6161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k error spam CI builds on travis occasionally freak out because of the recursive use of process.nextTick, which has been deprecated in Node relatively recently, to be replaced with setImmediate. As this issue is somewhat flakey, it's difficult to tell whether or not this will completely resolve the issue, but the hope is that it will.
|
I'm not actually sure this change would have any effect, looking at the source code it seems that it will still pick But the build passes tests, so it couldn't hurt that bad to merge it. |
|
This doesn't break anything, I'm just going to merge it after a rebase |
khepin
pushed a commit
to khepin/angular.js
that referenced
this pull request
Feb 19, 2014
CI builds on travis occasionally freak out because of the recursive use of process.nextTick, which has been deprecated in Node relatively recently, to be replaced with setImmediate. Unfortunately, this change does not resolve the issue. However, it does not hurt, either. Closes angular#6161
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI builds on travis occasionally freak out because of the recursive use of
process.nextTick, which has been deprecated in Node relatively recently, to be
replaced with setImmediate. As this issue is somewhat flakey, it's difficult
to tell whether or not this will completely resolve the issue, but the hope is
that it will.