This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($location): support alternative means of setting application base path #6129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… path
In HTML, the <base> tag is used to configure how relative hyperlinks are resolved. In Angular, it
has another use, configuring how URLs are rewritten. Because of this, setting the base URL to some
external path outside of the application would cause $location.$$parse() to throw (which is the
desired behaviour).
This change enables developers to imperatively configure the application basePath, taking advantage
of the natural HTML use of the <base> tag without breaking Angular applications.
Example:
```
angular.module("test", [])
.config(function($locationProvider) {
$locationProvider.baseHref("http://foo.com/the/base/application/path/");
});
```
Closes angular#4442
|
I'm not sure that it's much more complicated, but I see your point that a directive for specifying the app root url would be simpler. I think most of the extended problems mentioned on those issues are sort of unrelated, or tangentially related at best. What this really comes down to is how URLs are resolved, by the browser and by $location. N'either of those issues seem to be PRs implementing the declarative solution, though. |
|
+1 |
1 similar comment
|
+1 |
|
Base tags break SVG icons in FireFox. Without an officially documented way to set the baseHref of an application, we are left with either dropping support for browsers without history.pushState or decorating an internal, undocumented angular core service |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In HTML, the$location.$ $parse() to throw (which is the desired behaviour).
<base>tag is used to configure how relative hyperlinks are resolved. In Angular, it has another use, configuring how URLs are rewritten. Because of this, setting the base URL to some external path outside of the application would causeThis change enables developers to imperatively configure the application basePath, taking advantage of the natural HTML use of the tag without breaking Angular applications.
Example:
Closes #4442