Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

feat(jqLite): IE7 support for adding/removing CSS classes #6108

Closed
wants to merge 1 commit into from
Closed

feat(jqLite): IE7 support for adding/removing CSS classes #6108

wants to merge 1 commit into from

Conversation

fbenz
Copy link

@fbenz fbenz commented Feb 4, 2014

With this change most of Angular's features work again in IE7. As IE7 and below are not tested,
there is no guarantee what works and what not. Other browsers are not affected by the changes.

See #4562, #4880

With this change most of Angular's features work again in IE7. As IE7 and below are not tested,
there is no guarantee what works and what not. Other browsers are not affected by the changes.

See #4562, #4880
@caitp
Copy link
Contributor

caitp commented Feb 4, 2014

This is very similar to #5694 in implementation, however @wesleycho's version is a fair bit tidier. Thanks for the effort (it is appreciated!), but I expect that will be the fix to be merged.

@fbenz
Copy link
Author

fbenz commented Feb 4, 2014

Good to see that others are working on similar issues. However, I have tested #5694 in IE7 and it does not solve the problem - even if I include IE7 in the IE check. I am investigating whether small changes to #5694 can solve the problem for IE7. One of the problems is that the check for element.setAttribute returns true, but any access to get/setAttribute fails. Adding a prototype to these methods also does not work in IE7.

@tbosch tbosch self-assigned this Feb 5, 2014
@tbosch
Copy link
Contributor

tbosch commented Feb 5, 2014

Sorry, but this is a significant change in the codebase that we don't want to maintain going forward, so we won't accept this.

@tbosch tbosch closed this Feb 5, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants