Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Updating $provide.service method docs #6008

Closed
wants to merge 1 commit into from

Conversation

clark-pan
Copy link
Contributor

The previous example provided for the service method did not work. I've updated the example to a working example.

The previous example provided for the service method did not work.  I've updated the example to a working example.
@mary-poppins
Copy link

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@clark-pan
Copy link
Contributor Author

Bump. Signed CLA

@mary-poppins
Copy link

CLA signature verified! Thank you!

Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes).

@caitp
Copy link
Contributor

caitp commented Jan 29, 2014

Hey, so the example in the docs is returning the constructor for the Ping "class", the example doesn't really reflect that and would need to show it used as

var pinger = new ping();
pinger.send();

Or just having the service return new Ping();, this would be a much smaller change... But yeah I guess your version is probably the one that would make sense to people.

@caitp caitp closed this in e2173f9 Jan 29, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants