Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Update input.js #6000

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/ng/directive/input.js
Original file line number Diff line number Diff line change
Expand Up @@ -518,7 +518,10 @@ function textInputType(scope, element, attr, ctrl, $sniffer, $browser) {
if (attr.ngMinlength) {
var minlength = int(attr.ngMinlength);
var minLengthValidator = function(value) {
return validate(ctrl, 'minlength', ctrl.$isEmpty(value) || value.length >= minlength, value);
// this is the old expression. commit : https://github.com/angular/angular.js/commit/cdc4d485a6daa0c74e5d07d8def2a3ee68d93d13#diff-c244afd8def7f268b16ee91a0341c4b2R514
var oldExp = !ctrl.$isEmpty(value) && value.length < minlength;
// and now I just deny it.
return validate(ctrl, 'minlength', !oldExp, value);
};

ctrl.$parsers.push(minLengthValidator);
Expand All @@ -529,7 +532,10 @@ function textInputType(scope, element, attr, ctrl, $sniffer, $browser) {
if (attr.ngMaxlength) {
var maxlength = int(attr.ngMaxlength);
var maxLengthValidator = function(value) {
return validate(ctrl, 'maxlength', ctrl.$isEmpty(value) || value.length <= maxlength, value);
// this is the old expression. commit : https://github.com/angular/angular.js/commit/cdc4d485a6daa0c74e5d07d8def2a3ee68d93d13#diff-c244afd8def7f268b16ee91a0341c4b2R514
var oldExp = !ctrl.$isEmpty(value) && value.length > maxlength;
// and now I just deny it.
return validate(ctrl, 'maxlength', !oldExp, value);
};

ctrl.$parsers.push(maxLengthValidator);
Expand Down