Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Update step_00.ngdoc #5953

Closed
wants to merge 1 commit into from
Closed

Update step_00.ngdoc #5953

wants to merge 1 commit into from

Conversation

StevenInc
Copy link

The - (hyphen) renders as a special character in many browsers and make the document difficult to read.

The - (hyphen) renders as a special character in many browsers and make the document difficult to read.
@mary-poppins
Copy link

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@mary-poppins
Copy link

CLA signature verified! Thank you!

Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes).

@btford
Copy link
Contributor

btford commented May 24, 2014

For posterity, what browser are you seeing this behavior in?

@btford btford added this to the Purgatory milestone May 24, 2014
@sbenjamin
Copy link
Contributor

Chrome Browser Win 7

@petebacondarwin
Copy link
Contributor

@StevenInc Thanks for highlighting this. Is it because the browser is treating the hyphen as a potential line break and so removing it? Your change is not strictly correct though as the parentheses break the phrase at the wrong place. I am going to replace with a bullet list.

petebacondarwin added a commit that referenced this pull request Jul 3, 2014
Bootstrap CSS was removing the margin after ul elements if they were
descendents of other ul elements. But if the ul was followed by a p
then this looked terrible.

Related to #5953
petebacondarwin added a commit that referenced this pull request Jul 3, 2014
Bootstrap CSS was removing the margin after ul elements if they were
descendents of other ul elements. But if the ul was followed by a p
then this looked terrible.

Related to #5953
ckknight pushed a commit to ckknight/angular.js that referenced this pull request Jul 16, 2014
ckknight pushed a commit to ckknight/angular.js that referenced this pull request Jul 16, 2014
Bootstrap CSS was removing the margin after ul elements if they were
descendents of other ul elements. But if the ul was followed by a p
then this looked terrible.

Related to angular#5953
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants