Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(guide/directive): rephrase for consistency #5786

Closed
wants to merge 1 commit into from

Conversation

royling
Copy link
Contributor

@royling royling commented Jan 14, 2014

  • rephrase prop to attr (basically prop refers to property in JS object, attr is for HTML tag and also attr is used in directive api doc)
  • change the function name in description to hideDialog to match the name in code example

- change `prop` to `attr` (basically `prop` refers to property in JS object, `attr` is for HTML tag)
- change the function name in description to match the name in code example
@caitp caitp closed this in 51a7f9d Jan 15, 2014
jamesdaily pushed a commit to jamesdaily/angular.js that referenced this pull request Jan 27, 2014
- referring to `=attr` rather than `=prop` is consistent with note under example with =customerInfo
- change `prop` to `attr` (basically `prop` refers to property in JS object, `attr` is for HTML tag)
- change the function name in description to match the name in code example

Closes angular#5786
jamesdaily pushed a commit to jamesdaily/angular.js that referenced this pull request Jan 27, 2014
- referring to `=attr` rather than `=prop` is consistent with note under example with =customerInfo
- change `prop` to `attr` (basically `prop` refers to property in JS object, `attr` is for HTML tag)
- change the function name in description to match the name in code example

Closes angular#5786
@royling royling deleted the patch-1 branch March 8, 2017 13:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant