fix(ngMockE2E): added function parameter to $delegate on request passThrough #5783
Conversation
…Through The ngMockE2E $httpBackend has a mechanism to allows requests to pass through if one wants to send a real http request instead of mocking. The responseType of the request was never passed through to the real http module, as it was missing in the function parameter list. closes angular#5415
|
+1 to merging this. should be a no-brainer |
|
+1 to merging this |
|
+1 Please merge this one. This issue prevents mocking any service that returns any other type than string. |
|
+1. This is especially useful when one starts to use mock httpBackend for prototyping development, as with this pattern: http://cloudspace.com/blog/2014/03/27/backend-less-development-with-angular/#.U7RMZha6rGs |
petebacondarwin
force-pushed
the
master
branch
from
02dc2aa to
fd2d6c0
Compare
jeffbcross
force-pushed
the
master
branch
2 times, most recently
from
cad9560 to
f294244
Compare
jeffbcross
force-pushed
the
master
branch
4 times, most recently
from
e8dc429 to
e83fab9
Compare
petebacondarwin
force-pushed
the
master
branch
from
4dd5a20 to
998c61c
Compare
|
Can someone please commit this? |
|
+1. Any reason this has not been merged with yet? |
|
As already mentioned: This issue prevents mocking any service that returns any other type than string. |
…rough` The `ngMockE2E` `$httpBackend` has a mechanism to allow requests to pass through, if one wants to send a real HTTP request instead of mocking. The specified `responseType` of the request was never passed through to the "real" `$httpBackend` (of the `ng` module), resulting in it being effectively ignored. Fixes #5415 Closes #5783
…rough` The `ngMockE2E` `$httpBackend` has a mechanism to allow requests to pass through, if one wants to send a real HTTP request instead of mocking. The specified `responseType` of the request was never passed through to the "real" `$httpBackend` (of the `ng` module), resulting in it being effectively ignored. Fixes #5415 Closes #5783
|
@gkalpak - will there be a 1.4.10 release containing this fix or will we need to upgrade to 1.5.1 when it is released? |
|
It will be in |
The ngMockE2E $httpBackend has a mechanism to allows requests to pass through if one wants
to send a real http request instead of mocking. The responseType of the request was never
passed through to the real http module, as it was missing in the function parameter list.
closes #5415