This repository was archived by the owner on Apr 12, 2024. It is now read-only.
test(input): Minmaxlength databinding #5780
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
observing min/maxlength attributes
|
Just pinging this thread since it's fallen off, but reveals a bug in master. I doubt many people are relying on being able to dynamically change min/maxlength, but is it worth it to somehow retrigger validation inside those $observe handlers? |
|
Related #1405 Edit: made a mistake with the PR number |
|
This was introduced in 26d91b6 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some other threads we talked about testing for interpolated databinding in ngMaxLength / ngMinLength and I finally got around to it.
The databinding works fine, except if you change the length value without firing an input event. If I comment out the second calls to
changeInputValueTo(...)below, the tests will fail.How should we handle this?