fix(ngView, ngInclude): Add template to DOM before linking other directives #5367

tbosch · 2013-12-11T00:47:05Z

btford · 2013-12-13T00:34:19Z

src/ng/directive/ngInclude.js

+        $compile($element.contents())(scope);
+      }
+    };
+  }];


btford · 2013-12-13T01:04:18Z

aside from the EOL thing, LGTM

The template needs to be added to the DOM before other directives at the same element as `ngView` are linked. Related to angular#5247.

The template needs to be added to the DOM before other directives at the same element as `ngInclude` are linked. Fixes angular#5247.

tbosch · 2013-12-16T19:15:14Z

Landed in master in 1.2.5

btford reviewed Dec 13, 2013
View reviewed changes

src/ng/directive/ngInclude.js

$compile($element.contents())(scope);

}

};

}];

Copy link

Contributor

btford Dec 13, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EOL

tbosch added 2 commits December 12, 2013 17:06

fix(ngView): Add template to DOM before linking other directives

73624b2

The template needs to be added to the DOM before other directives at the same element as `ngView` are linked. Related to angular#5247.

fix(ngInclude): Add template to DOM before linking other directives

a2d1962

The template needs to be added to the DOM before other directives at the same element as `ngInclude` are linked. Fixes angular#5247.

ghost assigned tbosch Dec 16, 2013

tbosch closed this Dec 16, 2013

tbosch deleted the nginclude-template-link branch February 6, 2014 19:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(ngView, ngInclude): Add template to DOM before linking other directives #5367

fix(ngView, ngInclude): Add template to DOM before linking other directives #5367

tbosch commented Dec 11, 2013

btford Dec 13, 2013

btford commented Dec 13, 2013

tbosch commented Dec 16, 2013

fix(ngView, ngInclude): Add template to DOM before linking other directives #5367

fix(ngView, ngInclude): Add template to DOM before linking other directives #5367

Conversation

tbosch commented Dec 11, 2013

btford Dec 13, 2013

Choose a reason for hiding this comment

btford commented Dec 13, 2013

tbosch commented Dec 16, 2013