Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Update step_04.ngdoc #5356

Closed
wants to merge 1 commit into from
Closed

Update step_04.ngdoc #5356

wants to merge 1 commit into from

Conversation

TonyCronin
Copy link
Contributor

Grammatical. Change sentence from "If we had not set the default value here, the model would stay uninitialized until our user would pick an option from the drop down menu."

to

"If we had not set the default value here, the model would stay uninitialized until our user picks an option from the drop down menu."

Grammatical. Change sentence from "If we had not set the default value here, the model would stay uninitialized until our user would pick an option from the drop down menu."

to 

"If we had not set the default value here, the model would stay uninitialized until our user picks an option from the drop down menu."
@mary-poppins
Copy link

Thanks for the PR!

  • Contributor signed CLA now or in the past
    • If you just signed, leave a comment here with your real name
  • PR's commit messages follow the commit message format

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@IgorMinar
Copy link
Contributor

I'm sorry, but I wasn't able to verify your CLA signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let me know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@TonyCronin
Copy link
Contributor Author

I Apologise, just signed the CLA now.

Sent from my iPhone

On 10 Dec 2013, at 17:14, Igor Minar [email protected] wrote:

I'm sorry, but I wasn't able to verify your CLA signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let me know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.


Reply to this email directly or view it on GitHub.

@matsko
Copy link
Contributor

matsko commented Dec 10, 2013

@TonyCronin please update your commit message.

Here's an example:
docs(tutorial/step-6): remove unused class="diagram"

@TonyCronin
Copy link
Contributor Author

@matsko Apologies,
docs(tutorial/step-4):

changed: "If we had not set the default value here, the model would stay uninitialized until our user would pick an option from the drop down menu."

to

If we had not set the default value here, the model would stay uninitialized until our user picks an option from the drop down menu.

@TonyCronin
Copy link
Contributor Author

Apologies Victor, I've just signed the CLA again.

Tony 

On Dec 10, 2013, at 09:58 PM, Igor Minar [email protected] wrote:

I'm sorry, but I wasn't able to verify your CLA signature. CLA signature is required for any code contributions to AngularJS.
Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.
If you signed the CLA as a corporation, please let me know the company's name.
Thanks a bunch!
PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

Reply to this email directly or view it on GitHub.

@IgorMinar
Copy link
Contributor

CLA signature verified! Thank you!

Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes).

@TonyCronin
Copy link
Contributor Author

Thanks Igor. It's such a trivial change, I'm sorry for the bother now.

Sent from my iPhone

On 11 Dec 2013, at 00:15, Igor Minar [email protected] wrote:

CLA signature verified! Thank you!

Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes).


Reply to this email directly or view it on GitHub.

@matsko
Copy link
Contributor

matsko commented Dec 16, 2013

@TonyCronin update the commit message please!

jamesdaily pushed a commit to jamesdaily/angular.js that referenced this pull request Jan 27, 2014
jamesdaily pushed a commit to jamesdaily/angular.js that referenced this pull request Jan 27, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants