This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($compile): update cloned elements if the template arrives after the ... #5161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR!
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
| @@ -1330,23 +1330,25 @@ function getter(obj, path, bindFnToScope) { | |||
| } | |||
|
|
|||
| /** | |||
| * Return the siblings between `startNode` and `endNode`, inclusive | |||
| * @param {Object} object with `startNode` and `endNode` properties | |||
| * Return the DOM siblings between the first and the last node in the given array. | |||
There was a problem hiding this comment.
drop the 2nd "the" from "the first and the last." Should read "the first and last."
ghost
assigned 
…he cloning If an element has a directive whose content is loaded using `templateUrl`, and the element is cloned using a linking function before the template arrives, the clone needs to be updated as well. This also updates `ngIf` and `ngRepeat` to keep the connection to the clone of a tranclude function, so that they know about the changes a directive with `templateUrl` does to the element in the future. Fixes to angular#4930.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...cloning
If an element has a directive whose content is loaded using
templateUrl,and the element is cloned using a linking function before the template arrives,
the clone needs to be updated as well.
This also updates
ngIfandngRepeatto keep the connection to the cloneof a tranclude function, so that they know about the changes a directive with
templateUrldoes to the element in the future.Fixes to #4930.