This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(tests): Correct tests for IE11 #5075
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR!
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
| if (!msie || msie > 10) { | ||
| // style interpolation not working on IE<11. | ||
| if (!msie) { | ||
| // style interpolation not working on IE (including IE11). |
There was a problem hiding this comment.
can you just change 10 to 11?
it's preferable to keep the versions in the tests so that we know when thing start working. otherwise we'll need to check every single test after each ie release to see if some tests now pass.
|
the rest looks good to me! |
Some tests were wrong. However, src/* did not contain problems. Fixes angular#5046
|
Landed in master as 5792423 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests were wrong. However, src/* did not contain problems.
Fixes #5046