This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($compile): allow access to the controllers of transcluded elements f... #4959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1083,9 +1094,9 @@ function $CompileProvider($provide) { | |||
| * @returns {Function} | |||
| */ | |||
| function groupElementsLinkFnWrapper(linkFn, attrStart, attrEnd) { | |||
| return function(scope, element, attrs, controllers) { | |||
| return function(scope, element, attrs, controllers, $transclude) { | |||
…s from child elements. Additional API (backwards compatible) - Injects `$transclude` (see directive controllers) as 5th argument to directive link functions. - `$transclude` takes an optional scope as first parameter that overrides the bound scope. Deprecations: - `transclude` parameter of directive compile functions (use the new parameter for link functions instead). Refactorings: - Don't use comment node to temporarily store controllers - `ngIf`, `ngRepeat`, ... now all use `$transclude` Closes angular#4935.
|
@vojtajina Implemented all changes we discussed. Also changed the docs: I am not sure if this is the right way to mark deprecated arguments (third argument to the compile function)... |
|
@tbosch thanks a bunch, great work! I made a couple of little changes and merged it in as 90f8707. I don't like how we wrap/bind the transcludeFn many times (first we bind it to the proper scope, and then again to "current controllers"), however I don't wanna make bigger changes it now. The compiler code is too scary ;-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...rom child elements.
Additional API (backwards compatible)
$transclude(see directive controllers) as 5th argument to directive link functions.$transcludetakes an optional scope as first parameter that overrides thebound scope.
Deprecations:
transcludeparameter of directive compile functions (use the new parameter for link functions instead).Refactorings:
ngIf,ngRepeat, ... now all use$transcludeCloses #4935.