Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Make the default log behavior really not logging debug message #4953

Closed
wants to merge 1 commit into from

Conversation

michelsalib
Copy link

I think the documented behavior makes more sense, so it should be respected.

We keep the behavior to avoid BC, I am just updating the doc.

@petebacondarwin
Copy link
Contributor

I am afraid that the documentation was committed after the code, so it is arguably the documentation that is wrong.
Certainly it is easier to change the documentation to be accurate without potentially breaking people's applications.
You do have a point, though, that debug message should probably be turned off by default.

@michelsalib
Copy link
Author

I just fixed the PR to only change the documentation (this following the current code behavior that logs debug messages). I also squashed.

@michelsalib
Copy link
Author

ping @petebacondarwin.

@petebacondarwin
Copy link
Contributor

@michelsalib - thanks for updating. I think the new change actually breaks the sentence. But I will fix it up and merge.

@michelsalib michelsalib deleted the patch-1 branch November 20, 2013 21:15
jamesdaily pushed a commit to jamesdaily/angular.js that referenced this pull request Jan 27, 2014
jamesdaily pushed a commit to jamesdaily/angular.js that referenced this pull request Jan 27, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants