feat($resource): pass resource to the dynamic param function #4899
Conversation
ghost
assigned 
| return currentGroup; | ||
| }, | ||
| id: function(data) { | ||
| if (data !== undefined) { |
There was a problem hiding this comment.
I would do just return data && data.id;
There was a problem hiding this comment.
Changed while refactoring to new test.
|
I like this change. However, I don't think it needs to be part of the upcoming 1.2.1 "fix" release. |
|
No milestone was set. I set the milestone to |
|
I'm sorry, but I wasn't able to verify your CLA signature. CLA signature is required for any code contributions to AngularJS. Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match. If you signed the CLA as a corporation, please let me know the company's name. Thanks a bunch! PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR. |
|
CLA signature verified! Thank you! Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes). |
| @@ -433,7 +433,7 @@ angular.module('ngResource', ['ng']). | |||
| var ids = {}; | |||
| actionParams = extend({}, paramDefaults, actionParams); | |||
| forEach(actionParams, function(value, key){ | |||
| if (isFunction(value)) { value = value(); } | |||
| if (isFunction(value)) { value = value(data); } | |||
There was a problem hiding this comment.
can we add public docs for this change?
otherwise it looks good.
petebacondarwin
force-pushed
the
master
branch
from
02dc2aa to
fd2d6c0
Compare
jeffbcross
force-pushed
the
master
branch
2 times, most recently
from
cad9560 to
f294244
Compare
jeffbcross
force-pushed
the
master
branch
4 times, most recently
from
e8dc429 to
e83fab9
Compare
petebacondarwin
force-pushed
the
master
branch
from
4dd5a20 to
998c61c
Compare
petebacondarwin
modified the milestones:
1.5.x - migration-facilitation,
1.3.x - superluminal-nudge
No description provided.