This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Fixing bug where ngIf adds children repeatedly if condition goes from tr... #4894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test and fix are attached. |
|
Hi @matthughes thanks for the PR! Have you signed the CLA? Also, could you update your commit & PR messages per our commit message guidelines? |
|
Hi @jeffbcross, just in case you weren't aware, @IgorMinar has linked to a fix (albeit without tests), see #4852 (comment) and commit IgorMinar/directives-workshop@92c7fec |
ghost
assigned 
|
Closing this as solved by a different PR, see #4852. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for bug described in #4893