Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

chore(dependencies): revert to [email protected] to fix CI builds #4822

Closed
wants to merge 1 commit into from

Conversation

caitp
Copy link
Contributor

@caitp caitp commented Nov 7, 2013

marked v0.2.10 breaking test:docgen

Tests on travis have been failing the past few days, so I wanted to dig around for the cause.

To reproduce:

rm -rf node_modules/marked
npm install [email protected]
grunt test:docgen

(PASSES)

rm -rf node_modules/marked
npm install marked (now installs 0.2.10)
grunt test:docgen

(FAILS)

I think the simplest way to fix travis build would be to remove the ~ operator before the version number in package.json, but a more robust fix would involve migrating the code. Clearly there are some breaking changes introduced in v0.2.10

@caitp
Copy link
Contributor Author

caitp commented Nov 7, 2013

Hmm, well, mostly fixes CI builds... something is borked elsewhere I suppose, too :(

@petebacondarwin
Copy link
Contributor

@caitp - have you had a look at this PR: #4778 ? It is related I think.

@caitp
Copy link
Contributor Author

caitp commented Nov 7, 2013

I don't know if it solves all of the issues, but I'd be interested in seeing a saucelabs build to see how close it gets.

@caitp
Copy link
Contributor Author

caitp commented Nov 8, 2013

So, it looks like in order to migrate to 0.2.10, everything gets all async-crazy, and it doesn't seem very fun to migrate everything over. I'm not totally sure it's worth doing. Maybe some things could be wrapped in promises to keep it less crazy.

I'm not sure what is causing the travis failure for this quick fix though, for some reason my ie8 vm is not letting me reproduce the issue, so if someone has access to a legitimate windows PC to try and sort that out, that would be cool.

@caitp
Copy link
Contributor Author

caitp commented Nov 9, 2013

I guess the 95102a5 test still needs to be fixed, and I really don't understand what IE8 is complaining about since that file hasn't been touched in forever...

@petebacondarwin
Copy link
Contributor

Yes, Brian is going to take a look today/tomorrow at that test.

On 9 November 2013 23:25, Caitlin Potter [email protected] wrote:

I guess the 95102a595102a5afef6a6f36aefd3d3590e305cc972881dtest still needs to be fixed, and I really don't understand what IE8 is
complaining about since that file hasn't been touched in forever...


Reply to this email directly or view it on GitHubhttps://github.com//pull/4822#issuecomment-28139626
.

@petebacondarwin
Copy link
Contributor

@caitp - the travis build is failing for IE8 because of this change 5614fd2#diff-ce57d523476c1be91e154668e90187e9R196
I have a PR for this: #4875

jamesdaily pushed a commit to jamesdaily/angular.js that referenced this pull request Jan 27, 2014
The marked npm library brought in a breaking change at 0.2.10.
This commit ensures that we get exactly the version we want.

Closes angular#4822
jamesdaily pushed a commit to jamesdaily/angular.js that referenced this pull request Jan 27, 2014
The marked npm library brought in a breaking change at 0.2.10.
This commit ensures that we get exactly the version we want.

Closes angular#4822
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants