This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(ngInclude & ngView): Conditionally autoscroll after animation #4801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please fix all the small issues I noted and merge this into master |
We need to wait until animations have added the content to the document before trying to `autoscroll` to anchors that may have been inserted. Fixes angular#4723
ghost
assigned 
|
Merged |
|
Just googled this issue when searching for a solution of my problem. I have a site where user is navigating via top menu and pages are injected via ngView. Is there a way to make angular scroll the content to the top prior animating it? |
|
@lobodpav You should probably open a new issue with the problem description and add a reproduction (e.g. plunker) so the community can determine if it is a bug or not. |
|
Will do. Thx. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to wait until animations have added the content to the document before
trying to autoscroll to anchors that may have been inserted.