fix(ngList):Make ngList work with input of type email, url #4549

sudodoki · 2013-10-20T20:46:21Z

Validity for inputs are checked for single value using static regexp, which won't work with ngList directive on the input, since it's getting us an array of attributes.

Just like [https://github.com//pull/4295], but introducing every helper function, just as I mentioned at my last comment there.

mary-poppins · 2013-10-20T20:46:23Z

Thanks for the PR!

Contributor signed CLA now or in the past
- If you just signed, leave a comment here with your real name
PR's commit messages follow the commit message format

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

caitp · 2013-10-20T21:50:21Z

src/ng/directive/input.js

  ctrl.$parsers.push(function(value) {
    var empty = ctrl.$isEmpty(value);
-    if (empty || NUMBER_REGEXP.test(value)) {
+    if (empty ||  NUMBER_REGEXP.test(value)) {


This change doesn't seem necessary

sudodoki · 2013-10-20T23:14:18Z

@caitp thanks for feedback, changed this according to your comments.

caitp · 2013-10-27T21:40:27Z

src/ng/directive/input.js

@@ -4,6 +4,16 @@ var URL_REGEXP = /^(ftp|http|https):\/\/(\w+:{0,1}\w*@)?(\S+)(:[0-9]+)?(\/|\/([\
 var EMAIL_REGEXP = /^[A-Za-z0-9._%+-]+@[A-Za-z0-9.-]+\.[A-Za-z]{2,6}$/;
 var NUMBER_REGEXP = /^\s*(\-|\+)?(\d+|(\d*(\.\d*)))\s*$/;

+function every(array, fun) {


One thing though, because this is kind of a helper, it may be suitable to add it to src/Angular.js, along with the others. Even if it's not made public, it might help prevent similar additions from being added to other source files. Once triaged I'm sure the core team will have their own things to say about all of it

Validity for inputs are checked for single value using static regexp, which won't work with ngList directive on the input, since it's getting us an array of attributes.

sudodoki · 2013-10-27T22:26:34Z

Thanks @caitp once again. Updated PR.

redconfetti · 2013-11-18T21:05:48Z

If #4295 was closed in favor of #4549, then why was it closed also?

sudodoki · 2013-11-28T17:09:59Z

then why was it closed also?

It isn't, in fact.

@mary-poppins seems not to like the commit mesage, though it's copy of my previous one, that passed the check in #4295, same for the Contributor signed CLA checkbox.

sudodoki · 2014-02-04T12:31:30Z

This kinda went stale, should I update it?

redconfetti · 2014-02-04T17:26:43Z

I'm really confused how this isn't in fact closed. I'd say yes, update it.

RichardLitt · 2014-04-12T18:34:57Z

Is there any movement on this? What's needed next to merge it in?

…nput. It returns a string, not an array, but should be included as valid HTML and validated by Angular. angular#4549

RichardLitt · 2014-04-20T23:59:38Z

@caitp Do you know why every is failing in Travis? I pushed a second commit to fix my sloppy semicolon errors, but I'm not sure how to push that into the same PR, and I can't figure out why every is failing...

caitp · 2014-04-21T00:48:44Z

@RichardLitt The last build is failing because of jshint/jscs errors.

You can see them locally if you run grunt ci-checks

caitp · 2014-04-21T00:49:40Z

src/ng/directive/input.js

  var urlValidator = function(value) {
-    if (ctrl.$isEmpty(value) || URL_REGEXP.test(value)) {
+    if (isArray(value)) {
+      testedValid = every(value, function(val){return URL_REGEXP.test(val)})


You need a semicolon after return URL_REGEXP.test(val)

…gular.js angular#4549

RichardLitt · 2014-04-21T10:14:51Z

@caitp Thanks a lot! Edited those, declared every in the jshint area in build/angular.js. I'm not running into any errors locally if I run grunt ci-checks, but I wasn't before either, so I'm not sure what the deal is.

…gular.js angular#4549

… should work the same. Added semicolon. angular#4549

Narretz · 2014-06-23T17:08:42Z

when this finally lands, this will also close #4185

sudodoki · 2014-07-22T21:40:50Z

At the moment, I would suggest marking this as a known issue and just moving on to implement support for multiple attribute to work with email/url inputs, which would be more according to standards, which seems to be more angular-wayish.

caitp reviewed Oct 20, 2013
View reviewed changes

caitp reviewed Oct 27, 2013
View reviewed changes

fix(ngList):Make ngList work with input of type email, url

5e80c4f

Validity for inputs are checked for single value using static regexp, which won't work with ngList directive on the input, since it's getting us an array of attributes.

petebacondarwin mentioned this pull request Nov 12, 2013

Fix(input): make it work with ngList. #4295

Closed

Narretz mentioned this pull request Mar 18, 2014

emailInputType should support multiple attribute, similar to ngList #6032

Open

RichardLitt added a commit to RichardLitt/angular.js that referenced this pull request Apr 20, 2014

Fixed Travis erros hopefully angular#4549

620c467

RichardLitt added a commit to RichardLitt/angular.js that referenced this pull request Apr 21, 2014

Fixed Travis errors hopefully angular#4549

038619a

caitp reviewed Apr 21, 2014
View reviewed changes

RichardLitt added a commit to RichardLitt/angular.js that referenced this pull request Apr 21, 2014

Fixed travis errors by adding semicolons, declaring every in build/an…

183a941

…gular.js angular#4549

RichardLitt added a commit to RichardLitt/angular.js that referenced this pull request Apr 21, 2014

Fixed travis errors by adding semicolons, declaring every in build/an…

cd47933

…gular.js angular#4549

RichardLitt added a commit to RichardLitt/angular.js that referenced this pull request Apr 21, 2014

Removed .call() in favor of a simpler !fun(array[i]), which I believe…

e62a879

… should work the same. Added semicolon. angular#4549

RichardLitt added a commit to RichardLitt/angular.js that referenced this pull request Apr 27, 2014

Added every to jshint ignore angular#4549

d8bddf2

sudodoki closed this Jul 22, 2014

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(ngList):Make ngList work with input of type email, url #4549

fix(ngList):Make ngList work with input of type email, url #4549

sudodoki commented Oct 20, 2013

mary-poppins commented Oct 20, 2013

caitp Oct 20, 2013

sudodoki commented Oct 20, 2013

caitp Oct 27, 2013

sudodoki commented Oct 27, 2013

redconfetti commented Nov 18, 2013

sudodoki commented Nov 28, 2013

sudodoki commented Feb 4, 2014

redconfetti commented Feb 4, 2014

RichardLitt commented Apr 12, 2014

RichardLitt commented Apr 20, 2014

caitp commented Apr 21, 2014

caitp Apr 21, 2014

RichardLitt commented Apr 21, 2014

Narretz commented Jun 23, 2014

sudodoki commented Jul 22, 2014

fix(ngList):Make ngList work with input of type email, url #4549

fix(ngList):Make ngList work with input of type email, url #4549

Conversation

sudodoki commented Oct 20, 2013

mary-poppins commented Oct 20, 2013

caitp Oct 20, 2013

Choose a reason for hiding this comment

sudodoki commented Oct 20, 2013

caitp Oct 27, 2013

Choose a reason for hiding this comment

sudodoki commented Oct 27, 2013

redconfetti commented Nov 18, 2013

sudodoki commented Nov 28, 2013

sudodoki commented Feb 4, 2014

redconfetti commented Feb 4, 2014

RichardLitt commented Apr 12, 2014

RichardLitt commented Apr 20, 2014

caitp commented Apr 21, 2014

caitp Apr 21, 2014

Choose a reason for hiding this comment

RichardLitt commented Apr 21, 2014

Narretz commented Jun 23, 2014

sudodoki commented Jul 22, 2014